From 79a3e1941a3b6e06b1edda90ad27b956441eec6b Mon Sep 17 00:00:00 2001 From: Nemo D'ACREMONT Date: Mon, 16 Dec 2024 20:56:37 +0100 Subject: [PATCH] feat: weatherCachedData didn't throw exception on unknown city --- src/main/java/eirb/pg203/weather/data/api/OpenWeatherMap.java | 2 +- .../java/eirb/pg203/weather/data/api/WeatherCachedAPI.java | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/eirb/pg203/weather/data/api/OpenWeatherMap.java b/src/main/java/eirb/pg203/weather/data/api/OpenWeatherMap.java index f99314b..0fbfbeb 100644 --- a/src/main/java/eirb/pg203/weather/data/api/OpenWeatherMap.java +++ b/src/main/java/eirb/pg203/weather/data/api/OpenWeatherMap.java @@ -28,7 +28,7 @@ import eirb.pg203.weather.data.WeatherData.Condition; public class OpenWeatherMap extends WeatherCachedAPI { private static final String forecastBaseURL = "https://api.openweathermap.org/data/2.5/forecast"; private String APIKey; - private static Clock clock = Clock.systemUTC(); + public static Clock clock = Clock.systemUTC(); JSONFetcher JSONFetcher = new JSONFetcher(); public OpenWeatherMap(String APIKey) { diff --git a/src/main/java/eirb/pg203/weather/data/api/WeatherCachedAPI.java b/src/main/java/eirb/pg203/weather/data/api/WeatherCachedAPI.java index 9aec6d2..cd03623 100644 --- a/src/main/java/eirb/pg203/weather/data/api/WeatherCachedAPI.java +++ b/src/main/java/eirb/pg203/weather/data/api/WeatherCachedAPI.java @@ -39,9 +39,7 @@ public abstract class WeatherCachedAPI implements WeatherDataAPI { { if (this.cache.needsUpdate(cityName, i)) { - try { - updateCache(days, cityName); - } catch(Exception e) {} + updateCache(days, cityName); } }