From ad77a36da05c5eb3d667be1191c17d8b01434230 Mon Sep 17 00:00:00 2001 From: Martin Eyben Date: Tue, 19 Nov 2024 10:44:07 +0100 Subject: [PATCH] feat: refactor json fetcher --- .../java/eirb/pg203/utils/JSONFetcher.java | 30 +++++++++---------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/main/java/eirb/pg203/utils/JSONFetcher.java b/src/main/java/eirb/pg203/utils/JSONFetcher.java index 0c3cb9e..8827d0f 100644 --- a/src/main/java/eirb/pg203/utils/JSONFetcher.java +++ b/src/main/java/eirb/pg203/utils/JSONFetcher.java @@ -10,22 +10,8 @@ import org.json.JSONArray; import org.json.JSONObject; public class JSONFetcher { - public static JSONObject fetch(URL url) throws IOException { - StringBuilder result = new StringBuilder(); - HttpURLConnection conn = (HttpURLConnection) url.openConnection(); - conn.setRequestMethod("GET"); - try (BufferedReader reader = new BufferedReader( - new InputStreamReader(conn.getInputStream()))) { - for (String line; (line = reader.readLine()) != null; ) { - result.append(line); - } - } - - return new JSONObject(result.toString()); - } - - public static JSONArray fetchArray(URL url) throws IOException { + private static String fetchString(URL url) throws IOException{ StringBuilder result = new StringBuilder(); HttpURLConnection conn = (HttpURLConnection) url.openConnection(); conn.setRequestMethod("GET"); @@ -36,7 +22,19 @@ public class JSONFetcher { } } + return result.toString(); - return new JSONArray(result.toString()); + + } + public static JSONObject fetch(URL url) throws IOException { + String result = fetchString(url); + + return new JSONObject(result); + } + + public static JSONArray fetchArray(URL url) throws IOException { + String result = fetchString(url); + + return new JSONArray(result); } }